software, testing, service

How I solved code review process

Table of Contents

Share and Enjoy !

 

How I solved code review process
Last day I wrote an article on Problems of any automation testing….http://www.askqtp.com/2012/01/problems-of-any-automation-testing.html
Hope you have enjoyed that. Today I am going to tell you that how my manager and I solved those problem.
We were trying hard , team meeting, team building exercise, effective training ….but all went on vain. One fine afternoon I found an interesting article while setting up a process for myself. It was 11 Best Practices for Peer Code Review — a White Paper from Smart Bear.
I strongly recommend you to go through the original 
 As per the author—The review should be efficient light weight–
           1.  Review fewer than 200-400 lines of code at a time. Study says review 200-400 lines of code at a time in 60-90 minutes yields 70-90% efficiency. This is efficient as per my views.
we implemented this technique.
           2.  Aim for an inspection rate of less than 300-500 LOC/hour–
As per author if inspection rate (how fast are reviewers able to review code?) is optimal if he targets 300-500 LOC/hour.As per this white paper defect rate (how fast reviewer is getting defects) will be high in this zone.But when I tried to implement the same, I found,200-250 LOC/hour for testing  of Code is more than enough. Rest of time reviewer can still find out and validate the logic. We implemented this technique.
           3.  Author should annotate source code-yes,I agree with author,reviewer should write comment–let me twist a bit here for testing, reviewer should comment what logic is written as a block  of code. If it passes
4 Eye principle,it is done.we implemented this technique with some modification.
           4.  Smart Bear’s whitepaper’s author made a point that reviewer should quantify the code review and capture matrics. This can be done if a dedicated team is involved.on the other hand I must advocate for a new dimention to this–the matrix should be LOC vs logic corrected while running these script will tally application with requirement and find bugs.we implemented this technique.
            5.  Checklists improve result :
Well,well,I really admit this point of the author. Even as per the author “A Checklist” will remind authors and reviewers to confirm omission of any important aspect. I was very much motivated when they wrote–we can develop our own checklist.Even PSI,SEI,EMMI recommand such personal checklist. When I tried to implement in my current process.It really turned best.It yields nice result. We implemented this technique.
            
6. Fix problem on the fly: 
I like the author’s point here, verify the defects that are actually fixed. Yes I implemented in two folds. Moreso when a requirement review is done we changed our automation guideline on the fly and when we find some problem in automation Script, We fixed them during review.we implemented this technique.

Reference:-PEER code review checklist at www.CodeReviewBook.com


7. Initially,everything  went against us. All the given problem data was used against us.
And our objective became to pass a script anyway.Yes,I strongly agree with author’s line. If developers believe that metrics will be used against them,not only will they be hostile to the process,but they will probably focus on improving matrics rather than bug tracking. It happened with us also.We made our point very clear. We encouraged and educated them. It worked. 

Last point is the EGO effect:-

                                 I agree with the author of this white paper but also agree that seniors of a process become very much egoistic if any problem found on their code.Once,I remember one of my fellow senior test engineer blamed the junior reviewer when his test cases failed to execute.
                                 And have seen several occasions when seniors feel insulted when his/her test script(code) is reviewed by a junior member of the group.
                                 I have seen people has to influence reviewer to make his/her piece of code as pass,even if these are going to fail in long run just because,he is senior,he is from the same region,he is from same culture,languages etc etc.
Well, my manager was there to handle this..:)

                                 So,with the help of these points we found out a better solution .It was a great review process indeed.

Share and Enjoy !

33 thoughts on “How I solved code review process”

  1. I haven’t checked in here for some time because I thought it was getting boring, but the last few posts are great quality so I guess I will add you back to my daily bloglist. You deserve it my friend 🙂

  2. Great post. I was checking constantly this blog and I am impressed! Extremely helpful information specially the last part 🙂 I care for such info a lot. I was seeking this certain information for a very long time. Thank you and good luck.

  3. Good – I should definitely pronounce, impressed with your website. I had no trouble navigating through all tabs and related info ended up being truly simple to do to access. I recently found what I hoped for before you know it in the least. Quite unusual. Is likely to appreciate it for those who add forums or something, web site theme . a tones way for your client to communicate. Nice task..

  4. Hello.This post was extremely remarkable, particularly because I was looking for thoughts on this topic last Monday.

  5. Hi! Someone in my Facebook group shared this site with us so I
    came to take a look. I’m definitely enjoying the information. I’m bookmarking and will be tweeting
    this to my followers! Fantastic blog and amazing style
    and design.

  6. Hiya very nice blog!! Man .. Excellent .. Wonderful ..

    I will bookmark your blog and take the feeds additionally?
    I’m happy to search out numerous helpful info right here within the put up, we want develop more strategies on this regard, thank you for sharing.
    . . . . .

  7. Link exchange is nothing else except it is simply placing the other person’s weblog link on your page at suitable
    place and other person will also do same in support of
    you.

  8. I loved this post! I read your blog fairly often and you are always coming out with some great
    stuff. I will shares this on my facebook, instagram and
    some of my loyalty followers. Great jobs! Keep work it with it.

  9. I simply want to tell you that I am just all new to blogs and really liked you’re web blog. Very likely I’m planning to bookmark your website . You certainly have incredible article content. Cheers for revealing your blog site.

  10. You could certainly see your enthusiasm within the article you write.

    The arena hopes for more passionate writers like you who are not afraid to mention how they believe.
    All the time go after your heart.

  11. Thank you for any other informative blog. Where else
    could I get that type of info written in such an ideal way?

    I have a project that I am just now working on, and I have been at the look out for such information.

  12. You made some good points there. I looked on the web for more info about the issue and found most people will go along with your views on this website.

  13. You actually ensure it is seem so simple with your presentation however i find this matter to become really something that I feel I would never understand.

    It appears too complex and extremely broad to me. I am just
    looking forward for your post, I will try to obtain the hang than it!

  14. I don’t realize the way i finished up here, nevertheless i thought this post was good.
    I will not know what you are about but definitely you are attending a
    famous blogger when you will not be already 😉 Cheers!

  15. Fine way of telling, ɑnd fastidious paragraph too
    gett data аbout mmy presentatkon subject, wһiϲh i am gߋing to preѕent in institution oof һigher education.

  16. Pingback: Google

  17. Attractive portion of content. I simply stumbled upon your weblog and in accession capital to claim that I get actually enjoyed account your weblog posts.
    Anyway I will be subscribing on your augment and even I success you access persistently rapidly.

  18. Thanks for your marvelous posting! I certainly enjoyed
    reading it, you may be a great author. I will make certain to bookmark your
    blog and will often come back down the road. I want to
    encourage you continue your great posts, have a nice morning!

  19. I am really delighted to glance at this website posts which contains tons of valuable data,
    thanks for providing such data. adreamoftrains hosting services

  20. I will immediately take hold of your rss as I can not to
    find your e-mail subscription hyperlink or newsletter service.
    Do you’ve any? Please let me recognise in order that
    I may just subscribe. Thanks.

  21. Every weekend i used to go to see this website, because i
    want enjoyment, since this this site conations genuinely nice funny data too.

  22. Interesting blog! Is your theme custom made or did you download
    it from somewhere? A theme like yours with a few simple tweeks would really make
    my blog stand out. Please let me know where you got your design. Bless you

  23. Hmm is anyone else having problems with the pictures on this blog loading?

    I’m trying to find out if its a problem on my end or if
    it’s the blog. Any suggestions would be greatly appreciated.

  24. My spouse and I absolutely love your blog and find almost all of your
    post’s to be what precisely I’m looking for. can you offer guest writers to
    write content in your case? I wouldn’t mind composing a post or elaborating on a few of the subjects you write
    related to here. Again, awesome weblog!

  25. I’m gone to convey my little brother, that he should also pay a visit this website on regular
    basis to take updated from hottest information.

Leave a Comment

Your email address will not be published. Required fields are marked *